Commit Graph
4 Commits
Author SHA1 Message Date
Bo-Yi WuandGitHub 167b0f46ef chore(models): rewrite code format. (#14754)
* chore: rewrite format.

* chore: update format

Signed-off-by: Bo-Yi Wu <[email protected]>

* chore: update format

Signed-off-by: Bo-Yi Wu <[email protected]>

* chore: Adjacent parameters with the same type should be grouped together

* chore: update format.
2021-03-14 19:52:12 +01:00
b091c994b5 Comments on review should have the same sha (#13448)
* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <[email protected]>

* fix test

Signed-off-by: Andrew Thornton <[email protected]>

* Fix broken migration

Signed-off-by: Andrew Thornton <[email protected]>

* fix mssql

Signed-off-by: Andrew Thornton <[email protected]>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <[email protected]>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <[email protected]>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <[email protected]>

* fix mssql

Signed-off-by: Andrew Thornton <[email protected]>

* move session within the batch

Signed-off-by: Andrew Thornton <[email protected]>

* regen the sqlcmd each time round the loop

Signed-off-by: Andrew Thornton <[email protected]>

* as per @lunny

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
2020-11-09 01:15:09 -05:00
Lunny XiaoandGitHub 35cc82abbf Revert "Replies to outdated code comments should also be outdated (#13217)" (#13439)
This reverts commit 3cab3bee57.
2020-11-06 09:04:21 +02:00
3cab3bee57 Replies to outdated code comments should also be outdated (#13217)
* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <[email protected]>

* fix test

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
2020-11-04 17:55:15 -05:00