Commit Graph
2733 Commits
Author SHA1 Message Date
6543andGitHub fd60ebfe14 [API] Migration: Change ServiceType String (#12672)
* use different structs for MigrateRepoOptions on UI and API

* Fix TokenAuth and rename UID to an understandable Name

* fix swagger doc

* simplify & mk redable

* R E F A C T O R:
migration has now internal 3 structs to store its options:
 * the Options for WebUI: modules/auth/repo_form.go
 * the Options for API: modules/structs/repo.go
 * the option struct with after validation for internal prossessing: modules/migrations/base/options.go

* Copyright Header

* Deprecate UID - add RepoOwner

* adopt repo.go -> migrate.go

* add comment about each struct purpose

* lint
2020-09-10 23:29:19 +01:00
4f8dad37f8 ui: change commentTag style (#11668)
* ui: change commentTag style

* Add comment tag in first comment (issue content)
* Show CommentTagPoster in other way

Signed-off-by: a1012112796 <[email protected]>

* Update routers/repo/issue.go

Co-authored-by: Lauris BH <[email protected]>

* fix lint

* revert CommentTagPoster

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-09-10 14:09:14 -04:00
c3e8c9441a Add check for LDAP group membership (#10869)
This is a port of gogs/gogs#4398

The only changes made by myself are:

Add locales
Add some JS to the UI
Otherwise all code credit goes to @aboron

Resolves #10829

Signed-off-by: jolheiser <[email protected]>
Co-authored-by: zeripath <[email protected]>
2020-09-10 16:30:07 +01:00
Bagas SanjayaandGitHub 4c42fce401 Add placeholder text for bio profile text form (#12792)
* Add placeholder text
  * Localize
2020-09-10 15:29:26 +01:00
techknowlogickandGitHub 33ac0cc125 Set language via AJAX (#12785)
* Set language via AJAX

* fix lint
2020-09-10 09:09:23 +08:00
e153cf07c3 Add a migrate service type switch page (#12697)
* Add a migrat service type switch page

* Improve translations

* remove images

* Fix images

* remove extra create repo button on dashboard

* Follow reviewers' opinions

* Fix frontend lint

* Remove wrong submit file

* Fix tests

* Adjust the size of image

* Apply suggestions from code review

Co-authored-by: 赵智超 <[email protected]>

* Remove username and password from migration of github/gitlab

* Improve docs

* Improve interface docs

Co-authored-by: 赵智超 <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-09-09 14:29:10 -04:00
3865ecbf13 File header tweaks, add CSS helpers (#12635)
- replace two instances of fontawesome with octicons
- add new "class" optional argument to "svg" helper
- add many new CSS helpers and move their import to the end for
  increaseed precedence

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-09-08 13:17:56 -04:00
e204398754 Change/remove a branch of an open issue (#9080)
* Add field with isIssueWriter to front end

* Make branch field editable

* Switch frontend to form and POST from javascript

* Add /issue/id/ref endpoint to routes

* Use UpdateIssueTitle model to change ref in backend

* Removed crossreference check and adding comments on branch change

* Use ref returned from POST to update the field

* Prevent calling loadRepo from models/

* Branch/tag refreshed without page reload

* Remove filter for empty branch name

* Add clear option to tag list as well

* Delete button translation and coloring

* Fix for not showing selected branch name in new issue

* Check that branch is not being changed on a PR

* Change logic

* Notification when changing issue ref

* Fix for renamed permission parameter

* Fix for failing build

* Apply suggestions from code review

Co-authored-by: zeripath <[email protected]>

Co-authored-by: Gitea <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-09-08 12:29:51 -04:00
mrsdizzieandGitHub 489c8a1478 Compare SSH_DOMAIN when parsing submodule URLs (#12753)
Right now we only compare the hostname from a submodule with the prefixURL it is viewed from to check if the submodule is hosted on the same Gitea instance. This adds an additional check to compare it against SSH_DOMAIN as well since the same Gitea instance might have a different hostname for SSH and if the submodule uses that hostname we should also detect that and link to the proper DOMAIN value.

Fixes #12747, #9756
2020-09-07 20:08:10 -04:00
3408fb73b6 Add better Swagger description and a example for GetArchive (#12743)
Co-authored-by: techknowlogick <[email protected]>
2020-09-06 12:23:47 -04:00
赵智超andGitHub b613d70b41 ui: Show git-pull-request icon for closed pull request (#12742)
As title, I think it's more reasonable, and it's the same as GH.

Signed-off-by: a1012112796 <[email protected]>
2020-09-06 11:00:16 -04:00
1ea1cade85 Add Created & Updated to Milestone (#12662)
* Add Created and Updated to Milestone table and expose via API

* Expose to UI - To Overloaded ?!?

* fix unit test

Co-authored-by: techknowlogick <[email protected]>
2020-09-05 13:38:54 -04:00
Jochen PetersGitHubjochen@homeland <no-go@localhost>zeripath
385433d2f4 additional data for type StopWatch in swagger api (#12458)
* additional data for type StopWatch in swagger api

* fix lint-backend issue with gofmt

* fix format in v1_json with 'make generate-swagger'

* using issue.LoadRepo() instead of getRepositoryByID()

Co-authored-by: jochen@homeland <no-go@localhost>
Co-authored-by: zeripath <[email protected]>
2020-09-05 12:58:33 +01:00
6543andGitHub dba5d82f86 Expose Attachemnt Settings by API (#12514)
close #12368
2020-09-05 08:43:06 +01:00
2a52aeec49 API: Expose its limitation settings (#12714)
* API: Expose its limitation settings

* TESTs

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-09-04 14:10:15 -04:00
ca81b6528b UI: Inform user what meaning hourglass on reviews has (#12713)
Co-authored-by: techknowlogick <[email protected]>
2020-09-04 12:36:37 -04:00
72eeb13e4d Set avatar image dimensions (#12654)
Set the avatar image dimensions to help browsers
avoid layout reflows. Helps page load performance and
user experience (less content jank).

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-09-02 14:42:28 -04:00
3981f1b127 Remove duplicate logic in initListSubmits (#12660)
* Remove duplicate logic in initListSubmits

Using the same logic to handle Choosing reviewers and assignees as
choosing label. It's the first step of #10926.

Signed-off-by: a1012112796 <[email protected]>

* fix choose block

* fix nit

* try fix bug

* simple code

Co-authored-by: techknowlogick <[email protected]>
2020-09-02 12:55:13 -04:00
9bc69ff26e Support elastic search for code search (#10273)
* Support elastic search for code search

* Finished elastic search implementation and add some tests

* Enable test on drone and added docs

* Add new fields to elastic search

* Fix bug

* remove unused changes

* Use indexer alias to keep the gitea indexer version

* Improve codes

* Some code improvements

* The real indexer name changed to xxx.v1

Co-authored-by: zeripath <[email protected]>
2020-08-30 19:08:01 +03:00
zeripathandGitHub 17fbbe97d7 Do not disable commit changes button on repost (#12644)
If the user has pressed commit changes and the post has failed - do not disable
the commit changes button.

Fix #12072

Signed-off-by: Andrew Thornton <[email protected]>
2020-08-29 17:32:46 -04:00
d5b6931dbe [API] Delete Token accept names too (#12366)
* Delete Token accept names too

* better description

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
2020-08-28 11:09:33 +03:00
d3b5edacb6 Escape more things that are passed through str2html (#12622)
* Escape more things that are passed through str2html

Signed-off-by: Andrew Thornton <[email protected]>

* Bloody editors!

Co-authored-by: mrsdizzie <[email protected]>

* Update routers/user/oauth.go

Co-authored-by: mrsdizzie <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-08-28 00:37:05 -04:00
211321fb93 Git migration UX (#12619)
* Initial work

Signed-off-by: jolheiser <[email protected]>

* Implementation

Signed-off-by: jolheiser <[email protected]>

* Fix gitlab and token cloning

Signed-off-by: jolheiser <[email protected]>

* Imports and JS

Signed-off-by: jolheiser <[email protected]>

* Fix test

Signed-off-by: jolheiser <[email protected]>

* Linting

Signed-off-by: jolheiser <[email protected]>

* Generate swagger

Signed-off-by: jolheiser <[email protected]>

* Move mirror toggle and rename options

Signed-off-by: jolheiser <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
2020-08-28 09:36:37 +08:00
silverwindandGitHub f8601f3f09 Fix ellipsis in files table (#12617)
Turns out text ellispsis does not work in combination with flexbox and
while wrapping in a display:block can help in some cases, I could not
get this to work properly so this changes the truncate to inline-block
again and reduces the clickable area to just vertical expansion from the
links.
2020-08-27 21:45:37 +01:00
silverwindandGitHub e25d4867be Extract Swagger CSS to its own file (#12616) 2020-08-26 18:42:46 +01:00
65444c5ea3 Add link to home page on swagger ui (#12601)
* Add link to home page on swagger ui

Signed-off-by: a1012112796 <[email protected]>

* translate

* Apply review suggestion

* Move to right, Thanks @silverwind

* tweaks

Co-authored-by: silverwind <[email protected]>
Co-authored-by: John Olheiser <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-08-26 12:39:45 -04:00
7d14d6c1c1 Fix file table overflows (#12603)
- Fix overflow regression from https://github.com/go-gitea/gitea/pull/12553.
- Fix submodule columns stretching the table
- Refactor template to share more HTML nodes
- Introduce CSS helper classes

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-08-26 11:52:44 -04:00
zeripathandGitHub 69b3dd6362 Escape Email in forgot_password.tmpl (#12610)
Signed-off-by: Andrew Thornton <[email protected]>
2020-08-26 08:47:38 -05:00
6543andGitHub 4b97f9018b OpenGraph: use repo avatar if exist (#12586) 2020-08-24 22:46:56 +03:00
2ae8c7ab1c Add cron running API (#12421)
* Add cron running API

Signed-off-by: Andrew Thornton <[email protected]>

* Apply suggestions from code review

* placate-swagger

Signed-off-by: Andrew Thornton <[email protected]>

* return not found

Signed-off-by: Andrew Thornton <[email protected]>

* Apply suggestions from code review

Co-authored-by: techknowlogick <[email protected]>
2020-08-24 11:48:15 -04:00
ee047312a1 Fix emoji replacements, make emoji images consistent (#12567)
- Fix emoji not being replaced in issue title change text
- Make the image attributes consistent, add alt, remove align

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-08-23 21:44:53 -04:00
zeripathandGitHub 1bf7b8d7c1 Fix signing.wont_sign.%!s(<nil>) if Require Signing commits but not signed in (#12581)
signing.wont_sign.%!s(<nil>) will be displayed if the repository needs signed
commits but the user is not logged in.

This is displayed because of complicated logic in the the template repo/issue/view_content/pull.tmpl
and a shortcut in the code of routers/repo/issue.go

This PR adds a default value of notsignedin if users are not signed in, which
although our templates will not show will prevent custom templates from showing
the above.

It also fixes the template to avoid showing signing errors if the user is not
authorized to sign.

Replaces #12564
Close #12564

Signed-off-by: Andrew Thornton <[email protected]>
2020-08-23 22:59:41 +01:00
silverwindandGitHub dd8ec12188 Increase clickable area on files table links (#12553) 2020-08-23 20:05:17 +01:00
赵智超andGitHub e7d65cbc6e Add email notify for new release (#12463)
* Add email notify for new release

Signed-off-by: a1012112796 <[email protected]>
2020-08-23 16:03:18 +01:00
d4e35b9dc6 Hide 'New Project board' button for users that are not signed in (#12547)
* hide: 'New Project board' button

* there is no reason to show the button for users that are not signed in

* update template: specifies the condition together with another one

as per lafriks' suggestion in the comment

* chore: add proper user authorization check

* chore: also hide button if repo is archived

* chore: show project board edit/delete menu to authorized users only

* chore: drop the redundant IsSigned check

* CanWriteIssues and CanWritePulls implies (and requires) signed in user

* Add CanWriteProjects and properly assert permissions

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Andrew Thornton <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-08-22 02:58:59 -04:00
fff0204cab Add placeholder text for "Add SSH/GPG Key" forms (#12533)
* Add placeholder text for "Add SSH/GPG Key" forms

This commit add placeholder text for both Add SSH key and Add GPG key
forms.

* Localize placeholders

Changes requested by @zeripath

Co-authored-by: techknowlogick <[email protected]>
2020-08-20 11:51:34 -04:00
6543andGitHub dcb543ac2a Show 2FA info on Admin Pannel: Users List (#12515) 2020-08-20 09:53:49 +08:00
1984b6a11b Milestone Issue/Pull List: Add octicons type (#12499)
* add octicons based on issue type (pull|issue)

* handle IsRead again

* short code

Co-authored-by: techknowlogick <[email protected]>
2020-08-17 15:11:42 -04:00
+3 4027c5dd7c Kanban board (#8346)
Co-authored-by: 6543 <[email protected]>
Co-authored-by: jaqra <[email protected]>
Co-authored-by: Kerry <[email protected]>
Co-authored-by: Jaqra <[email protected]>
Co-authored-by: Kyle Evans <[email protected]>
Co-authored-by: Tsakiridis Ilias <[email protected]>
Co-authored-by: Ilias Tsakiridis <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: silverwind <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-08-16 23:07:38 -04:00
zeripathandGitHub d1e67d7ade Fix bug preventing transfer to private organization (#12497)
* Fix bug preventing transfer to private organization

The code assessing whether a private organization was visible to a user before
allowing transfer was incorrect due to testing membership the wrong way round

This PR fixes this issue and renames the function performing the test to be
clearer.

Further looking at the API for transfer repository - no testing was
performed to ensure that the acting user could actually see the new
owning organization.

Signed-off-by: Andrew Thornton <[email protected]>

* change IsUserPartOfOrg everywhere
2020-08-16 16:27:08 -04:00
a4ba1ad5ed Add placeholder text for send testing email button in admin/config (#12452)
* Add placeholder text for send testing email button in admin/config

* Change placeholder text to expecting email address

* Localize placeholder text

* Apply suggestion from @silverwind

ok

Co-authored-by: silverwind <[email protected]>

Co-authored-by: silverwind <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2020-08-10 22:38:30 -04:00
zeripathandGitHub 96add8c319 Do not show arrows on comment diffs on pull comment pages (#12434)
* Do not show arrows on comment diffs on pull comment pages

Prior to this PR it was possible that an expansion arrow could be displayed
on comment diffs displayed on the comments pages of pulls

These arrows would not successfully work because they were not attached to
a commit id - nor can they necessarily be.

This PR prevents these from being shown.

Fix #10851

Signed-off-by: Andrew Thornton <[email protected]>

* as per @silverwind

Signed-off-by: Andrew Thornton <[email protected]>

* one more indentation fix

Signed-off-by: Andrew Thornton <[email protected]>

* one more indentation fix

Signed-off-by: Andrew Thornton <[email protected]>
2020-08-08 09:22:34 +08:00
2c1ae6c82d Render the git graph on the server (#12333)
Rendering the git graph on the server means that we can properly track flows and switch from the Canvas implementation to a SVG implementation.

* This implementation provides a 16 limited color selection
* The uniqued color numbers are also provided
* And there is also a monochrome version
*In addition is a hover highlight that allows users to highlight commits on the same flow.

Closes #12209

Signed-off-by: Andrew Thornton [email protected]
Co-authored-by: silverwind <[email protected]>
2020-08-06 09:04:08 +01:00
f1a42f5d5e Add SVG favicon (#12437)
Co-authored-by: Lunny Xiao <[email protected]>
2020-08-06 08:04:51 +01:00
983cbb2c9f Remove librejs header in <head> (#12439)
For the sake of performance and simplicity, remove this seemingly useless
license header. It's related to LibreJS which we already pretty much
killed of in an earlier commit [1]. Initially added in [2]. Note that
the StaticUrlPrefix here was never actually correctly resolved and has
rendered including the template fences.

[1] https://github.com/go-gitea/gitea/pull/11810
[2] https://github.com/go-gitea/gitea/commit/a915a09e4f8edc7734c9374ad9f9a51b39241ee3

Co-authored-by: techknowlogick <[email protected]>
2020-08-06 09:44:27 +08:00
Andreas ShimokawaandGitHub e5c5080f26 In issue comments, put issue participants also in completion list when hitting @ (#12433)
Previous behaviour was only to have completion for project members
2020-08-06 00:18:21 +01:00
2872a04f27 UserProfile Page: Render Description (#12415)
* If Description contain more that one line render it

* simpler ...

* only render if description exists

* Fix NPE in tests

* Update routers/user/profile.go

Co-authored-by: zeripath <[email protected]>
2020-08-05 15:48:37 +08:00
6ab4d76ced Match GH with Commit page (#12425)
Co-authored-by: zeripath <[email protected]>
2020-08-05 09:32:13 +08:00
zeripathandGitHub 33391e04fe Prevent empty div when editing comment (#12404)
* Prevent empty div when editing comment

The template for attachments needs to remove whitespace and return empty when there are no attachments.

Fix #10220
2020-08-04 22:30:02 +01:00
赵智超andGitHub 8a6790b2aa Add API to update pr headBranch (#12419)
* [API] Add update pr headBranch api

Signed-off-by: a1012112796 <[email protected]>
2020-08-04 21:55:22 +01:00