Commit Graph
11946 Commits
Author SHA1 Message Date
zeripathandGitHub 1904941382 Add test to ensure that dumping of login sources remains correct (#16847)
#16831 has occurred because of a missed regression. This PR adds a simple test to
try to prevent this occuring again.

Signed-off-by: Andrew Thornton <[email protected]>
2021-08-28 04:25:27 +01:00
KN4CK3RandGitHub 88abb0dc8a Decoupled code from DefaultSigningKey (#16743)
Decoupled code from `DefaultSigningKey`. Makes testing a little bit easier and is cleaner.
2021-08-27 20:28:00 +01:00
zeripathandGitHub cd8db3a83d Prevent "Race" detected in TestAdmin*User (#16830)
These tests are missing the defer prefix.

Related #1441

Signed-off-by: Andrew Thornton <[email protected]>
2021-08-27 15:00:37 +02:00
e37342db0c Add modals to Organization and Team remove/leave (#16471)
* Add modals to Organization and Team remove/leave

Add confirmation modals to Organization and Team remove and leave.

Fix #16215

Signed-off-by: Andrew Thornton <[email protected]>

* avoid for-in

Signed-off-by: Andrew Thornton <[email protected]>

* Revert "avoid for-in"

This reverts commit 2af9a6f9d46ed31b6fc6e3a29e695577dcf09f75.

* Apply suggestions from code review

Co-authored-by: silverwind <[email protected]>

Co-authored-by: 6543 <[email protected]>
Co-authored-by: silverwind <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2021-08-26 22:57:40 -04:00
GiteaBot 3289aceec2 [skip ci] Updated translations via Crowdin 2021-08-27 00:04:45 +00:00
b60e814055 Enable race detector for CI (#1441)
* Enable race detector by default

Set RACE_ENABLED=0 to disable it when release

* Disable race detector for release builds

* use `true`

* fix

* debug issue

* fix

* verbose

* clean

* Fix wrong merge

* Fix coverage merge

Co-authored-by: Mura Li <[email protected]>
Co-authored-by: 6543 <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
2021-08-26 16:50:04 +08:00
GiteaBot c446901a5d [skip ci] Updated translations via Crowdin 2021-08-26 00:04:46 +00:00
ba6baff696 Report the correct number of pushes on the feeds (#16811)
* Report the correct number of pushes on the feeds

Since the number of commits in the Action table has been limited to 5
the number of commits reported on the feeds page is now incorrectly also
limited to 5. The correct number is available as the Len and this PR
changes this to report this.

Fix #16804

Signed-off-by: Andrew Thornton <[email protected]>

* Update templates/user/dashboard/feeds.tmpl

Co-authored-by: techknowlogick <[email protected]>
2021-08-25 19:04:58 -04:00
28ac4a7a87 Add EdDSA JWT signing algorithm (#16786)
* Add EdDSA signing algorithm

* Fix typo

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
2021-08-25 16:50:38 -04:00
Clar FonandGitHub 29b971b6d5 Actually compute proper foreground color for labels (#16729) 2021-08-25 12:55:47 -05:00
20efc6b56c Unify migration descriptions (#16781)
* Unify migration descriptions

* Clarify that pure Git migration differs from other migrations

Co-authored-by: Norwin <[email protected]>

* Use Pull Requests for Gitea migration

Co-authored-by: Norwin <[email protected]>
Co-authored-by: zeripath <[email protected]>
2021-08-25 21:47:05 +08:00
Lunny XiaoandGitHub b88dbe1208 Use a common quote to instead of check database type (#16817)
`` ` `` will be converted to different database quote by xorm. So check database type is unnecessary.
2021-08-25 13:23:34 +01:00
zeripathandGitHub 697213bdb3 Add primary_key to issue_index (#16813)
Make the group_id a primary key in issue_index. This already has an unique index
and therefore is a good candidate for becoming a primary key.

This PR also changes all other uses of this table to add the group_id as the
primary key.

Fix #16802

Signed-off-by: Andrew Thornton <[email protected]>
2021-08-25 09:42:51 +01:00
zeripathandGitHub e891d68dd7 Prevent NPE on empty commit (#16812) 2021-08-24 19:33:23 -04:00
Lunny XiaoandGitHub 4e761fa385 Fix branch pagination error (#16805)
Fix #16801

Even if default branch is removed from the current page, but the total branches number should be still kept. So that the pagination calculation will be correct.
2021-08-24 23:15:07 +01:00
Lunny XiaoandGitHub efaf109435 Add information for migrate failure (#16803)
Improve the reporting of errors when there is a migration failure
2021-08-24 18:46:55 +01:00
John OlheiserandGitHub 648464b504 Add bundle download for repository (#14538)
* Add bundle download

Signed-off-by: jolheiser <[email protected]>

* Fix fmt

Signed-off-by: jolheiser <[email protected]>

* Fix build tags

Signed-off-by: jolheiser <[email protected]>

* Download specific commit

Signed-off-by: jolheiser <[email protected]>
2021-08-24 11:47:09 -05:00
GiteaBot d22cb600ed [skip ci] Updated translations via Crowdin 2021-08-24 00:04:47 +00:00
921afb57fb Add missing return to handleSettingRemoteAddrError (#16794)
There is a missing return in handleSettingRemoteAddrError which means
that the error page for repo settings is duplicately rendered.

Fix #16771

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
2021-08-23 18:09:25 -04:00
1cd4a3b963 Update caddyserver/certmagic (#16789)
Fixes issue with windows users & letsencrypt

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
2021-08-23 18:07:40 -04:00
zeripathandGitHub f31e7a67cf Just use a slice when rendering file (#16774)
Highlight currently uses a map which is memory inefficient. Switch to use a slice instead.

Signed-off-by: Andrew Thornton <[email protected]>
2021-08-23 22:23:39 +01:00
zeripathandGitHub 73defbbd1c Ensure that template compilation panics are sent to the logs (#16788)
Although panics within the rendering pipeline are caught and dealt with,
panics that occur before that starts are unprotected and will kill Gitea
without being sent to the logs.

This PR adds a basic recovery handler to catch panics that occur after
the logger is initialised and ensure that they're sent to the logger.

Signed-off-by: Andrew Thornton <[email protected]>
2021-08-23 20:40:59 +01:00
GiteaBot 94f529af02 [skip ci] Updated translations via Crowdin 2021-08-23 00:04:31 +00:00
techknowlogickandGitHub db1e3d02a5 frontport: 1.15.0 changelog (#16772)
* frontport: 1.15.0 changelog

* Update config.yaml
2021-08-22 20:29:51 +01:00
b55c699c62 Alter issue/comment table TEXT fields to LONGTEXT (#16765)
* Alter issue/comment table TEXT fields to LONGTEXT

* Use If not Switch

Co-authored-by: zeripath <[email protected]>
2021-08-22 23:33:05 +08:00
zeripathandGitHub 7f85610942 Fix openidConnect source regression from #16544 (#16759)
Unfortunately there is bug in #16544 meaning that openid connects aren't
being matched properly as the capitalisation in that PR is incorrect.

This PR changes the capitalisation back to what is expected.

Signed-off-by: Andrew Thornton <[email protected]>
2021-08-22 10:17:05 +01:00
GiteaBot 208ae9e996 [skip ci] Updated licenses and gitignores 2021-08-22 00:06:14 +00:00
KN4CK3RandGitHub cee5f7c5e2 Add migrate from OneDev (#16356)
* Use context to simplify logic.

* Added migration from OneDev.
This PR adds [OneDev](https://code.onedev.io/) as migration source.

Supported:
- [x] Milestones
- [x] Issues
- [x] Pull Requests
- [x] Comments
- [x] Reviews
- [x] Labels
2021-08-22 00:47:45 +02:00
wxiaoguangandGitHub 2d1935acc7 Upgrade go.mod go version to 1.16 (#16764) 2021-08-21 20:04:17 +01:00
AbnerandGitHub 7844bf1430 Download lfs in git and web workflow from minio/s3 directly (#16731) 2021-08-21 20:22:06 +02:00
wxiaoguangandGitHub 06f82641cb when the update request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates (#16762) 2021-08-21 14:04:47 +01:00
0bd58d61e5 Added introspection endpoint. (#16752)
Co-authored-by: Lunny Xiao <[email protected]>
2021-08-20 22:16:45 -04:00
e9747de952 Fix dependency link rendering in PR sidebar (#16754)
Signed-off-by: Steven Kriegler <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: zeripath <[email protected]>
2021-08-21 01:02:47 +01:00
StevenandGitHub 3ecc4a1b9e Fix dependency translations (#16753)
Signed-off-by: Steven Kriegler <[email protected]>
2021-08-21 00:13:45 +01:00
dc2613600c Keep attachments on tasklist update (#16750)
* Send attachments too.

* Use tasklist flag.

* use action="ignoreAttachments" instead of "tasklist"

* Use boolean parameter.

Co-authored-by: zeripath <[email protected]>
2021-08-20 15:26:19 -04:00
3b2ed4762e Do not use thin scrollbars on Firefox (#16738)
In #7269, thin scrollbars were added in Arc Green theme. It got moved
in base theme in #13361.

This PR removes the use of thin scrollbars which causes an
accessibility issue. The scrollbars become too thin to be dragged.

Signed-off-by: Elouan Martinet <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
2021-08-19 17:31:47 -04:00
zeripathandGitHub 03937891e2 Return nil proxy function if proxy not enabled (#16742)
Signed-off-by: Andrew Thornton <[email protected]>
2021-08-19 16:41:20 -04:00
KN4CK3RandGitHub 4debb74eda Fix wrong user in OpenID response (#16736)
* Fixed usage of wrong user.

* Added tests.
2021-08-19 12:11:30 -04:00
c9bca8c5e0 Recreate Tables should Recreate indexes on MySQL (#16718)
The MySQL indexes are not being renamed at the same time as RENAME table despite the
CASCADE. Therefore it is probably better to just recreate the indexes instead.

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: 6543 <[email protected]>
2021-08-19 07:11:36 +03:00
4aa3cacc4f Add edit button to wiki sidebar and footer (#16719)
* Add edit button to wiki sidebar and footer

* Make edit button transparent

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
2021-08-18 14:14:08 -04:00
9f0c8f90af Fix migration svg color (#16715)
* Fixed svg color.

* Use --color-text.

Co-authored-by: Lauris BH <[email protected]>
2021-08-19 00:07:52 +08:00
f9acad82ca Add proxy settings and support for migration and webhook (#16704)
* Add proxy settings and support for migration and webhook

* Fix default value

* Add newline for example ini

* Add lfs proxy support

* Fix lint

* Follow @zeripath's review

* Fix git clone

* Fix test

* missgin http requests for proxy

* use empty

Co-authored-by: zeripath <[email protected]>

Co-authored-by: 6543 <[email protected]>
Co-authored-by: zeripath <[email protected]>
2021-08-18 21:10:39 +08:00
422c30d315 Refactored and fixed migration tests. (#16714)
Co-authored-by: techknowlogick <[email protected]>
2021-08-17 20:47:18 -04:00
GiteaBot 65c6acccf6 [skip ci] Updated translations via Crowdin 2021-08-18 00:04:48 +00:00
e0853d4a21 Add API Token Cache (#16547)
One of the issues holding back performance of the API is the problem of hashing.
Whilst banning BASIC authentication with passwords will help, the API Token scheme
still requires a PBKDF2 hash - which means that heavy API use (using Tokens) can
still cause enormous numbers of hash computations.

A slight solution to this whilst we consider moving to using JWT based tokens and/or
a session orientated solution is to simply cache the successful tokens. This has some
security issues but this should be balanced by the security issues of load from
hashing.

Related #14668

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
2021-08-17 14:30:42 -04:00
274aeb3a9e build with go1.17 (#16707)
Co-authored-by: Lauris BH <[email protected]>
2021-08-17 08:31:28 -04:00
techknowlogickandGitHub 37d0d94843 Use github token URL when fetching oauth token (#16709)
Fixes regression from #16544
2021-08-17 09:07:52 +01:00
ea07726dc1 Update JS dependencies (#16708)
* Update JS dependencies

- Update all JS dependencies
- Adapt to recent webpack changes
- Add new lint rules and fix issues
- Regenerate SVGs and update svgo api usage

Fixes: https://github.com/go-gitea/gitea/pull/16492

* adapt jest config and sort keys

Co-authored-by: Lunny Xiao <[email protected]>
2021-08-17 01:32:48 -04:00
GiteaBot cf4328359b [skip ci] Updated translations via Crowdin 2021-08-17 00:07:42 +00:00
GiteaBot fe3299614a [skip ci] Updated translations via Crowdin 2021-08-16 00:07:41 +00:00